linux-kernel - Re: [PATCH v7] rust: alloc: satisfy POSIX alignment requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72=FhaZrgMTBSTXOQvg8jrAR+pbdUjt2gL2npjBh8881jw@mail.gmail.com>
Date: Thu, 6 Mar 2025 00:02:05 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, DJ Delorie <dj@...hat.com>, 
	Eric Blake <eblake@...hat.com>, Paul Eggert <eggert@...ucla.edu>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-man@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] rust: alloc: satisfy POSIX alignment requirement

On Thu, Feb 13, 2025 at 12:34 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> ISO C's `aligned_alloc` is partially implementation-defined; on some
> systems it inherits stricter requirements from POSIX's `posix_memalign`.
>
> This causes the call added in commit dd09538fb409 ("rust: alloc:
> implement `Cmalloc` in module allocator_test") to fail on macOS because
> it doesn't meet the requirements of `posix_memalign`.
>
> Adjust the call to meet the POSIX requirement and add a comment. This
> fixes failures in `make rusttest` on macOS.
>
> Acked-by: Danilo Krummrich <dakr@...nel.org>
> Fixes: dd09538fb409 ("rust: alloc: implement `Cmalloc` in module allocator_test")
> Signed-off-by: Tamir Duberstein <tamird@...il.com>

Applied to `rust-fixes` -- thanks everyone!

    [ Added Cc: stable. - Miguel ]

Cheers,
Miguel