linux-kernel - RE: [EXTERNAL] Re: [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA6PR21MB423103A7760280380AAED1EBCECB2@SA6PR21MB4231.namprd21.prod.outlook.com>
Date: Wed, 5 Mar 2025 23:29:20 +0000
From: Long Li <longli@...rosoft.com>
To: Jakub Kicinski <kuba@...nel.org>, "longli@...uxonhyperv.com"
	<longli@...uxonhyperv.com>
CC: Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
	Konstantin Taranov <kotaranov@...rosoft.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
	<pabeni@...hat.com>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [patch rdma-next v4 1/2] net: mana: Change the
 function signature of mana_get_primary_netdev_rcu

> On Wed,  5 Mar 2025 14:22:39 -0800 longli@...uxonhyperv.com wrote:
> > +	netdev_hold(ndev, NULL, GFP_ATOMIC);
> 
> 😅️
> 
> I asked you to use this API for the tracker functionality, obviously.
> Please don't pass NULL in.

Is it okay to put the tracker in another device? (it's not the same device as the event netdev where netdev_hold() is used)

Sorry I'm not clear about where to put the tracker.