linux-kernel - Re: [PATCH v5 1/4] ACPI: APEI: Move apei_hest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250305233403.GA322933@bhelgaas>
Date: Wed, 5 Mar 2025 17:34:03 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: LeoLiu-oc <LeoLiu-oc@...oxin.com>
Cc: rafael@...nel.org, lenb@...nel.org, james.morse@....com,
	tony.luck@...el.com, bp@...en8.de, bhelgaas@...gle.com,
	robert.moore@...el.com, yazen.ghannam@....com, avadhut.naik@....com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, acpica-devel@...ts.linux.dev,
	CobeChen@...oxin.com, TonyWWang@...oxin.com, ErosZhang@...oxin.com,
	leoliu@...oxin.com
Subject: Re: [PATCH v5 1/4] ACPI: APEI: Move apei_hest_parse() to apei.h

On Wed, Feb 26, 2025 at 08:18:35PM +0800, LeoLiu-oc wrote:
> From: LeoLiuoc <LeoLiu-oc@...oxin.com>
> 
> Remove static from apei_hest_parse() so that it can be called in another
> file.

> +++ b/drivers/acpi/apei/hest.c
> @@ -134,7 +134,7 @@ static bool is_ghes_assist_struct(struct acpi_hest_header *hest_hdr)
>  
>  typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
>  
> -static int apei_hest_parse(apei_hest_func_t func, void *data)
> +int apei_hest_parse(apei_hest_func_t func, void *data)
>  {
>  	struct acpi_hest_header *hest_hdr;
>  	int i, rc, len;
> diff --git a/include/acpi/apei.h b/include/acpi/apei.h
> index dc60f7db5524..b79976daa4bb 100644
> --- a/include/acpi/apei.h
> +++ b/include/acpi/apei.h
> @@ -33,6 +33,8 @@ void __init acpi_ghes_init(void);
>  static inline void acpi_ghes_init(void) { }
>  #endif
>  
> +int apei_hest_parse(apei_hest_func_t func, void *data);

Series doesn't build after this patch because we lack the
apei_hest_func_t typedef:

  $ make drivers/acpi/apei/
    CC      drivers/acpi/apei/apei-base.o
  In file included from drivers/acpi/apei/apei-base.c:30:
  ./include/acpi/apei.h:36:21: error: unknown type name ‘apei_hest_func_t’
     36 | int apei_hest_parse(apei_hest_func_t func, void *data);
	|                     ^~~~~~~~~~~~~~~~

The kernel must build and function correctly after each and every
patch in the series.