linux-kernel - [PATCH v2 2/2] HID: Intel-thc-hid: Intel-quickspi: Change device state correctly after S4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250305033331.2544941-3-even.xu@intel.com>
Date: Wed,  5 Mar 2025 11:33:31 +0800
From: Even Xu <even.xu@...el.com>
To: jikos@...nel.org,
	bentiss@...nel.org
Cc: srinivas.pandruvada@...ux.intel.com,
	mpearson-lenovo@...ebb.ca,
	linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Even Xu <even.xu@...el.com>
Subject: [PATCH v2 2/2] HID: Intel-thc-hid: Intel-quickspi: Change device state correctly after S4

During S4 retore flow, quickspi device was reset by driver and state
was changed to QUICKSPI_RESET. It is needed to be change to
QUICKSPI_ENABLED state after S4 re-initialization finished, otherwise,
device will run in wrong state and HID input data will be dropped.

Signed-off-by: Even Xu <even.xu@...el.com>
Fixes: 6912aaf3fd24 ("HID: intel-thc-hid: intel-quickspi: Add PM implementation")
---
 drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
index 59d0b71e6e4f..9170af9be777 100644
--- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
+++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
@@ -909,6 +909,8 @@ static int quickspi_restore(struct device *device)
 
 	thc_change_ltr_mode(qsdev->thc_hw, THC_LTR_MODE_ACTIVE);
 
+	qsdev->state = QUICKSPI_ENABLED;
+
 	return 0;
 }
 
-- 
2.40.1