linux-kernel - Re: [PATCH] drm/panel: fix Visionox RM692E5 dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02fb7b29-6af0-40f2-a187-326fd762835a@linaro.org>
Date: Wed, 5 Mar 2025 08:44:07 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Danila Tikhonov <danila@...xyga.com>, Eugene Lepshy <fekz115@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>, Jessica Zhang <quic_jesszhan@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 David Wronek <david@...nlining.org>, Sumit Semwal <sumit.semwal@...aro.org>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: fix Visionox RM692E5 dependencies

On 04/03/2025 15:29, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added driver uses the DSC helpers, so the corresponding
> Kconfig option must be enabled:
> 
> ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-visionox-rm692e5.ko] undefined!
> 
> Fixes: 7cb3274341bf ("drm/panel: Add Visionox RM692E5 panel driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/gpu/drm/panel/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 5927806cb4a9..e059b06e0239 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -1020,6 +1020,8 @@ config DRM_PANEL_VISIONOX_RM692E5
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_DSC_HELPER
> +	select DRM_DISPLAY_HELPER
>   	help
>   	  Say Y here if you want to enable support for Visionox RM692E5 amoled
>   	  display panels, such as the one found in the Nothing Phone (1)

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>