linux-kernel - Re: [PATCH v7 3/5] Add debugfs based silicon debug support in DWC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250305074447.GC847772@rocinante>
Date: Wed, 5 Mar 2025 16:44:47 +0900
From: 'Krzysztof Wilczyński' <kw@...ux.com>
To: Shradha Todi <shradha.t@...sung.com>
Cc: 'Geert Uytterhoeven' <geert@...ux-m68k.org>,
	'Fan Ni' <nifan.cxl@...il.com>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-perf-users@...r.kernel.org, manivannan.sadhasivam@...aro.org,
	lpieralisi@...nel.org, robh@...nel.org, bhelgaas@...gle.com,
	jingoohan1@...il.com, Jonathan.Cameron@...wei.com,
	a.manzanares@...sung.com, pankaj.dubey@...sung.com,
	cassel@...nel.org, 18255117159@....com, xueshuai@...ux.alibaba.com,
	renyu.zj@...ux.alibaba.com, will@...nel.org, mark.rutland@....com,
	'Yoshihiro Shimoda' <yoshihiro.shimoda.uh@...esas.com>,
	'Linux-Renesas' <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v7 3/5] Add debugfs based silicon debug support in DWC

Hello,

> I think we shouldn't move the log level to be a WARN. I believe many
> controllers might not support RAS DES feature in their design and giving
> a warn dump would draw unnecessary attention.

There will be no backtrack printed with neither dev_err() nor dev_warn(),
which is what we were using here.  Using dev_WARN() or the WARN() macro
directly would be an overkill in this case, indeed.

> My opinion is to silently let it fail unless the user is actually
> interested in getting the RAS DES feature up.

I think, what we have there now is fine.  We don't error on the lack of RAS
DES capability when the platform does not support it, and only return an
error following a memory allocation failure, which should ideally never
happen.

That said, have a look at the following:

  https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/dwc

This is how the code looks like at the moment.

We can still move it to dev_dbg(), so basically suppress any errors or
warnings from being printed outside of the debug log level, if you think
it would be better.

Thank you!

	Krzysztof