linux-kernel - Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7sngbgx.fsf@kernel.org>
Date: Wed, 05 Mar 2025 08:53:18 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Guilherme Giacomo Simoes" <trintaeoitogc@...il.com>,
  <alex.gaynor@...il.com>,  <aliceryhl@...gle.com>,  <apw@...onical.com>,
  <arnd@...db.de>,  <aswinunni01@...il.com>,  <axboe@...nel.dk>,
  <benno.lossin@...ton.me>,  <bhelgaas@...gle.com>,
  <bjorn3_gh@...tonmail.com>,  <boqun.feng@...il.com>,  <dakr@...nel.org>,
  <dwaipayanray1@...il.com>,  <ethan.twardy@...il.com>,
  <fujita.tomonori@...il.com>,  <gary@...yguo.net>,
  <gregkh@...uxfoundation.org>,  <joe@...ches.com>,
  <linux-kernel@...r.kernel.org>,  <lukas.bulwahn@...il.com>,
  <ojeda@...nel.org>,  <pbonzini@...hat.com>,
  <rust-for-linux@...r.kernel.org>,  <tmgross@...ch.edu>,
  <walmeida@...rosoft.com>
Subject: Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

"Miguel Ojeda" <miguel.ojeda.sandonis@...il.com> writes:

> On Tue, Mar 4, 2025 at 10:00 PM Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
>>
>> I think it could be a good idea (it would be lovely to write the
>> checker in Rust -- I also had a checker bot in Python from the old
>> days of the old `rust` branch in GitHub), but `checkpatch.pl` doesn't
>> need a built kernel, so it would be a disadvantage or at least a
>> difference w.r.t. the usual `checkpatch.pl`, and we may not be able to
>> call it from `checkpatch.pl`.
>
> By "built kernel", I don't mean an entire kernel, but rather having to
> call `make` in general, i.e. we could have a target to build just the
> script, but still, it is a difference.

Right, it needs a bit more tool support than running checkpatch.pl
needs. Perhaps we could move it from checkpatch.pl to the rustfmt make
target?


Best regards,
Andreas Hindborg