linux-kernel - Re: [PATCH RESEND v2] drivers: core: fix device leak in __fw_devlink_relax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250305090705.4b2eb1e9@booty>
Date: Wed, 5 Mar 2025 09:07:05 +0100
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich
 <dakr@...nel.org>, Saravana Kannan <saravanak@...gle.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, Hervé Codina
 <herve.codina@...tlin.com>, linux-kernel@...r.kernel.org, Andrew Morton
 <akpm@...ux-foundation.org>, stable@...r.kernel.org
Subject: Re: [PATCH RESEND v2] drivers: core: fix device leak in
 __fw_devlink_relax_cycles()

Hello Greg,

On Mon, 3 Mar 2025 15:07:53 +0100
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Mon, Mar 03, 2025 at 10:30:51AM +0100, Luca Ceresoli wrote:
> > Commit bac3b10b78e5 ("driver core: fw_devlink: Stop trying to optimize
> > cycle detection logic") introduced a new struct device *con_dev and a
> > get_dev_from_fwnode() call to get it, but without adding a corresponding
> > put_device().
> > 
> > Closes: https://lore.kernel.org/all/20241204124826.2e055091@booty/
> > Fixes: bac3b10b78e5 ("driver core: fw_devlink: Stop trying to optimize cycle detection logic")
> > Cc: stable@...r.kernel.org
> > Reviewed-by: Saravana Kannan <saravanak@...gle.com>
> > Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> > ---
> > Changes in v2:
> > - add 'Cc: stable@...r.kernel.org'
> > - use Closes: tag, not Link:
> > - Link to v1: https://lore.kernel.org/r/20250212-fix__fw_devlink_relax_cycles_missing_device_put-v1-1-41818c7d7722@bootlin.com
> > ---
> >  drivers/base/core.c | 1 +
> >  1 file changed, 1 insertion(+)  
> 
> This was applied to my tree on Feb 20, right?  Or is this a new version?
> Why was it resent?

I just didn't know it got applied, sorry for the noise. Being a fix, I
was expecting to see it in current master where but it isn't there yet.
Assuming it will be soon, you can ignore it.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com