linux-kernel - Re: [PATCH] serial: icom: fix inconsistent indenting warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91d7a427-a297-4169-ac8d-af0ef4863d99@kernel.org>
Date: Wed, 5 Mar 2025 09:45:19 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Charles Han <hanchunchao@...pur.com>, gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: icom: fix inconsistent indenting warning

On 05. 03. 25, 9:37, Charles Han wrote:
> Fix below inconsistent indenting smatch warning.
> smatch warnings:
> drivers/tty/serial/icom.c:1768 icom_probe() warn: inconsistent indenting
> 
> Signed-off-by: Charles Han <hanchunchao@...pur.com>
> ---
>   drivers/tty/serial/icom.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c
> index 29e42831df39..6779d8ea1487 100644
> --- a/drivers/tty/serial/icom.c
> +++ b/drivers/tty/serial/icom.c
> @@ -1764,11 +1764,11 @@ static int icom_probe(struct pci_dev *dev,
>   		goto probe_exit1;
>   	}
>   
> -	 /* save off irq and request irq line */
> -	 retval = request_irq(dev->irq, icom_interrupt, IRQF_SHARED, ICOM_DRIVER_NAME, (void *)icom_adapter);
> -	 if (retval) {
> -		  goto probe_exit2;
> -	 }
> +	/* save off irq and request irq line */
> +	retval = request_irq(dev->irq, icom_interrupt,
> +			IRQF_SHARED, ICOM_DRIVER_NAME, (void *)icom_adapter);

In fact, if you removed that useless (void *) too, the code would fit on 
a single 100c line.

> +	if (retval)
> +		goto probe_exit2;

You removed also { and }. That has nothing to do with the $SUBJECT or 
commit log.

thanks,
-- 
js
suse labs