linux-kernel - Re: [PATCH net] netpoll: guard __netpoll_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250305-tamarin-of-amusing-luck-b9c84f@leitao>
Date: Wed, 5 Mar 2025 01:09:49 -0800
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Amerigo Wang <amwang@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-team@...a.com
Subject: Re: [PATCH net] netpoll: guard __netpoll_send_skb() with RCU read
 lock

Hello Jakub,

On Tue, Mar 04, 2025 at 05:47:32PM -0800, Jakub Kicinski wrote:
> On Mon, 03 Mar 2025 03:44:12 -0800 Breno Leitao wrote:
> > +	guard(rcu)();
> 
> Scoped guards if you have to.
> Preferably just lock/unlock like a normal person..

Sure, I thought that we would be moving to scoped guards all across the
board, at least that was my reading for a similar patch I sent a while
ago:

	https://lore.kernel.org/all/20250224123016.GA17456@noisy.programming.kicks-ass.net/

Anyway, in which case should I use scoped guard instead of just being
like a normal person?

Thanks for the review,
--breno