linux-kernel - Re: [PATCH v3 0/6] ASoC: q6apm: fix under runs and fragment sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8gXh4CrVJPznNvC@hovoldconsulting.com>
Date: Wed, 5 Mar 2025 10:21:11 +0100
From: Johan Hovold <johan@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
	krzysztof.kozlowski@...aro.org, linux-sound@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	dmitry.baryshkov@...aro.org, johan+linaro@...nel.org
Subject: Re: [PATCH v3 0/6] ASoC: q6apm: fix under runs and fragment sizes

On Wed, Mar 05, 2025 at 10:06:52AM +0100, Johan Hovold wrote:
> On Tue, Mar 04, 2025 at 06:19:53PM +0100, Johan Hovold wrote:
> > On Tue, Mar 04, 2025 at 05:12:20PM +0000, Srinivas Kandagatla wrote:
> > > On 04/03/2025 17:04, Johan Hovold wrote:
> > 
> > > > Unfortunately, this series still regresses Pulseaudio as capture is now
> > > > choppy (e.g. when recording using parecord).
> > > > 
> > > > During our off-list debugging sessions you suggested reducing the max
> > > > capture period size (that this series increases) to 6144 (same as min)
> > > > and that fixed the Pulseaudio capture issue. In v3 the, the max period
> > > > is again increased to 65536 which appears to break Pulseaudio capture.
> > > 
> > > I have verified pulseaudio on my side as well, the 64 byte alignment 
> > > should have fixed the issue on the pulseaudio side.
> > > 
> > > Did you pick up the [PATCH v3 4/6] ASoC: qdsp6: q6apm-dai: set correct 
> > > period and buffer alignment. patch in your tests?
> > 
> > Yes, I'm running with the full series applied. I tested PA on the X13s
> > (and PW on the T14s).
> 
> I just tested PA on the T14s and it has the same problem with
> choppy recording with this series applied.
> 
> As with the (amended) v2, setting the max capture period size to 6144
> appears to make the problem go away.

Actually, there may still be some distortion also with the max period
size capped at 6144 with PA (there's a hint of it breaking up as with
the non-modified v3). At least the PW recording sounded cleaner, even if
I guess there could be other causes for this.
 
Johan