linux-kernel - Re: [PATCH v2 1/1] accel/habanalabs: Switch to use %ptTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8gb_kzQ7COAUqnB@smile.fi.intel.com>
Date: Wed, 5 Mar 2025 11:40:14 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	"Avizrat, Yaron" <yaron.avizrat@...el.com>,
	"Elbaz, Koby" <koby.elbaz@...el.com>,
	"Sinyuk, Konstantin" <konstantin.sinyuk@...el.com>
Subject: Re: [PATCH v2 1/1] accel/habanalabs: Switch to use %ptTs

On Tue, Mar 04, 2025 at 09:01:59PM +0200, Jani Nikula wrote:
> On Thu, 06 Feb 2025, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > Use %ptTs instead of open-coded variant to print contents of time64_t type
> > in human readable form.

...

> > -	char pq_time_str[64] = "N/A", eq_time_str[64] = "N/A";
> 
> The "N/A" gets replaced with, I presume, "1970-01-01 00:00:00" for 0
> timestamps, which is not the same thing.

It's used only in dev_err() below which is why it's fine to update.
Should I mention this in the commit message?

> But I honestly don't know anything about the driver.

-- 
With Best Regards,
Andy Shevchenko