linux-kernel - Re: [PATCH v3 2/7] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8gehLMlc1qiA2HE@pengutronix.de>
Date: Wed, 5 Mar 2025 10:51:00 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Sebastian Reichel <sre@...nel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	linux-pm@...r.kernel.org,
	Søren Andersen <san@...v.dk>
Subject: Re: [PATCH v3 2/7] power: reset: Introduce PSCR Recording Framework
 for Non-Volatile Storage

On Tue, Mar 04, 2025 at 02:24:28PM +0100, Oleksij Rempel wrote:
> +/**
> + * set_power_state_change_reason - Record reason for next reboot/shutdown
> + * @reason: The enumerated reason code to record
> + *
> + * Other drivers (e.g. regulator, thermal) call this whenever they detect
> + * a condition that may lead to or cause a reboot.
> + */
> +void set_power_state_change_reason(enum pscr_reason reason);

this declaration should be removed, otherwise it fails on disabled
CONFIG_PSCRR.
...

> +#if IS_ENABLED(CONFIG_PSCRR)
> +
> +void set_power_state_change_reason(enum pscr_reason pscr);
> +
> +#else
> +
> +static inline void set_power_state_change_reason(enum pscr_reason pscr)
> +{
> +}
> +#endif
 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |