linux-kernel - Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8gnvXQ9OMXoq9Fz@smile.fi.intel.com>
Date: Wed, 5 Mar 2025 12:30:21 +0200
From: Andy Shevchenko <andy@...nel.org>
To: George Cherian <george.cherian@...vell.com>
Cc: linux@...ck-us.net, wim@...ux-watchdog.org, jwerner@...omium.org,
	evanbenn@...omium.org, kabel@...nel.org, krzk@...nel.org,
	mazziesaccount@...il.com, thomas.richard@...tlin.com,
	lma@...omium.org, bleung@...omium.org,
	support.opensource@...semi.com, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	paul@...pouillou.net, alexander.usyskin@...el.com,
	andreas.werner@....de, daniel@...ngy.jp, romain.perier@...il.com,
	avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
	maddy@...ux.ibm.com, mpe@...erman.id.au, npiggin@...il.com,
	christophe.leroy@...roup.eu, naveen@...nel.org, mwalle@...nel.org,
	xingyu.wu@...rfivetech.com, ziv.xu@...rfivetech.com,
	hayashi.kunihiko@...ionext.com, mhiramat@...nel.org,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	chrome-platform@...ts.linux.dev, imx@...ts.linux.dev,
	linux-mips@...r.kernel.org, openbmc@...ts.ozlabs.org,
	linuxppc-dev@...ts.ozlabs.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

On Wed, Mar 05, 2025 at 10:10:24AM +0000, George Cherian wrote:
> A new option flag is added to watchdog_info. This helps the watchdog
> core to check whether stop functions would sleep or not.
> The option flags of individual drivers are also updated accordingly.

...

>  	.options =	WDIOF_SETTIMEOUT |
>  			WDIOF_MAGICCLOSE |
> -			WDIOF_KEEPALIVEPING,
> +			WDIOF_KEEPALIVEPING |
> +			WDIOF_STOP_MAYSLEEP,

You may heavily reduce this change if you squeeze the new option just before
the last one. Currently it's a lot of unneeded churn that makes review a bit
harder (each needs to be carefully checked for the correctness).

-- 
With Best Regards,
Andy Shevchenko