linux-kernel - Re: [PATCH] KVM: x86: Always set mp_state to RUNNABLE on wakeup from HLT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174078620474.3857606.12481651463517277322.b4-ty@google.com>
Date: Tue,  4 Mar 2025 17:05:14 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Always set mp_state to RUNNABLE on wakeup from HLT

On Mon, 24 Feb 2025 09:41:56 -0800, Sean Christopherson wrote:
> When emulating HLT and a wake event is already pending, explicitly mark
> the vCPU RUNNABLE (via kvm_set_mp_state()) instead of assuming the vCPU is
> already in the appropriate state.  Barring a KVM bug, it should be
> impossible for the vCPU to be in a non-RUNNABLE state, but there is no
> advantage to relying on that to hold true, and ensuring the vCPU is made
> RUNNABLE avoids non-deterministic behavior with respect to pv_unhalted.
> 
> [...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: Always set mp_state to RUNNABLE on wakeup from HLT
      https://github.com/kvm-x86/linux/commit/2a289aed3fcd

--
https://github.com/kvm-x86/linux/tree/next