linux-kernel - Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8gohVIQqlA6QquZ@smile.fi.intel.com>
Date: Wed, 5 Mar 2025 12:33:41 +0200
From: Andy Shevchenko <andy@...nel.org>
To: George Cherian <george.cherian@...vell.com>
Cc: linux@...ck-us.net, wim@...ux-watchdog.org, jwerner@...omium.org,
	evanbenn@...omium.org, kabel@...nel.org, krzk@...nel.org,
	mazziesaccount@...il.com, thomas.richard@...tlin.com,
	lma@...omium.org, bleung@...omium.org,
	support.opensource@...semi.com, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
	paul@...pouillou.net, alexander.usyskin@...el.com,
	andreas.werner@....de, daniel@...ngy.jp, romain.perier@...il.com,
	avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
	venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
	maddy@...ux.ibm.com, mpe@...erman.id.au, npiggin@...il.com,
	christophe.leroy@...roup.eu, naveen@...nel.org, mwalle@...nel.org,
	xingyu.wu@...rfivetech.com, ziv.xu@...rfivetech.com,
	hayashi.kunihiko@...ionext.com, mhiramat@...nel.org,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	chrome-platform@...ts.linux.dev, imx@...ts.linux.dev,
	linux-mips@...r.kernel.org, openbmc@...ts.ozlabs.org,
	linuxppc-dev@...ts.ozlabs.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier
 callback

On Wed, Mar 05, 2025 at 10:10:25AM +0000, George Cherian wrote:
> Watchdog is not turned off in kernel panic situation.
> In certain systems this might prevent the successful loading
> of kdump kernel. The kdump kernel might hit a watchdog reset
> while it is booting.
> 
> To avoid such scenarios add a panic notifier call back function
> which can stop the watchdog. This provision can be enabled by
> passing watchdog.stop_on_panic=1 via kernel command-line parameter.

...

First of all, do we really need a new module parameter for that? Why can't it
be done automatically if kdump is expected?

> +static bool stop_on_panic;
> +module_param(stop_on_panic, bool, 0444);
> +MODULE_PARM_DESC(stop_on_panic, "Stop watchdogs on panic (0=keep watching, 1=stop)");

+ blank line.

Also I do not see the documentation update. Where is it lost?

>  /*

-- 
With Best Regards,
Andy Shevchenko