linux-kernel - Re: [PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8grs3uva8j2qrKP@smile.fi.intel.com>
Date: Wed, 5 Mar 2025 12:47:15 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-wpan@...r.kernel.org,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>
Subject: Re: [PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using
 gpiod API

On Wed, Mar 05, 2025 at 08:04:17AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Mar 04, 2025 at 01:22:34PM +0200, Andy Shevchenko wrote:
> > This updates the driver to gpiod API, and removes yet another use of
> > of_get_named_gpio().
> > 
> > With this, invert the logic of the reset pin which is active low
> > and add a quirk for the legacy and incorrect device tree descriptions.
> > 
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  .../bindings/net/ieee802154/ca8210.txt        |  2 +-
> 
> Bindings are always separate patches.

Okay.

> Please run scripts/checkpatch.pl and fix reported warnings.
> After that,
> run also 'scripts/checkpatch.pl --strict' and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in touch
> if the warning is not clear.

-- 
With Best Regards,
Andy Shevchenko