linux-kernel - Re: [PATCH 10/14] soc: hisilicon: kunpeng_hccs: Simplify PCC shared memory region handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250305113426.bt2lebp2rfyngcpl@bogus>
Date: Wed, 5 Mar 2025 11:34:26 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: "lihuisong (C)" <lihuisong@...wei.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Adam Young <admiyo@...amperecomputing.com>
Subject: Re: [PATCH 10/14] soc: hisilicon: kunpeng_hccs: Simplify PCC shared
 memory region handling

On Wed, Mar 05, 2025 at 03:14:50PM +0800, lihuisong (C) wrote:
> 
> 在 2025/3/3 18:51, Sudeep Holla 写道:
> > The PCC driver now handles mapping and unmapping of shared memory
> > areas as part of pcc_mbox_{request,free}_channel(). Without these before,
> > this Kunpeng HCCS driver did handling of those mappings like several
> > other PCC mailbox client drivers.
> > 
> > There were redundant operations, leading to unnecessary code. Maintaining
> > the consistency across these driver was harder due to scattered handling
> > of shmem.
> > 
> > Just use the mapped shmem and remove all redundant operations from this
> > driver.
> > 
> > Cc: Huisong Li <lihuisong@...wei.com>
> > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> With belows to change,
> Reviewed-by: Huisong Li <lihuisong@...wei.com>

Thanks!

[...]

> > -	if (!pcc_chan->shmem_base_addr ||
> > -	    pcc_chan->shmem_size != HCCS_PCC_SHARE_MEM_BYTES) {
> > +	if (pcc_chan->shmem_size != HCCS_PCC_SHARE_MEM_BYTES) {
> >   		dev_err(dev, "The base address or size (%llu) of PCC communication region is invalid.\n",
> >   			pcc_chan->shmem_size);
> 
> Now the check of shared base address is not here. The log about this address
> no need to be printed.
> 
> Can you help me fix it like:
> 
> dev_err(dev, "The base size (%llu) of PCC communication region must be %d Byte.\n",
>  			pcc_chan->shmem_size, HCCS_PCC_SHARE_MEM_BYTES
> );

Sure.

Did you get a chance to validate this driver and any other users of PCC
on your platform with these changes + the error handling fix you pointed
out ? That would be very useful as I don't have any set up to test.

--
Regards,
Sudeep