linux-kernel - Re: [PATCH v6] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11F973B4-D5B5-48F8-B53B-693C8DED5DA1@live.com>
Date: Wed, 5 Mar 2025 11:57:04 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Petr Mladek <pmladek@...e.com>, Steven Rostedt <rostedt@...dmis.org>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>, "senozhatsky@...omium.org"
	<senozhatsky@...omium.org>, Jonathan Corbet <corbet@....net>, Andrew Morton
	<akpm@...ux-foundation.org>, "apw@...onical.com" <apw@...onical.com>,
	"joe@...ches.com" <joe@...ches.com>, "dwaipayanray1@...il.com"
	<dwaipayanray1@...il.com>, "lukas.bulwahn@...il.com"
	<lukas.bulwahn@...il.com>
CC: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, Linux Kernel
 Mailing List <linux-kernel@...r.kernel.org>, Hector Martin
	<marcan@...can.st>, Sven Peter <sven@...npeter.dev>, Janne Grunau
	<j@...nau.net>, Alyssa Rosenzweig <alyssa@...enzweig.io>, Asahi Linux Mailing
 List <asahi@...ts.linux.dev>
Subject: Re: [PATCH v6] lib/vsprintf: Add support for generic FourCCs by
 extending %p4cc



> On 2 Mar 2025, at 7:12 AM, Aditya Garg <gargaditya08@...e.com> wrote:
> 
> From: Hector Martin <marcan@...can.st>
> 
> %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but
> it's useful to be able to print generic 4-character codes formatted as
> an integer. Extend it to add format specifiers for printing generic
> 32-bit FourCCs with various endian semantics:
> 
> %p4ch Host byte order
> %p4cn Network byte order
> %p4cl Little-endian
> %p4cb Big-endian
> 
> The endianness determines how bytes are interpreted as a u32, and the
> FourCC is then always printed MSByte-first (this is the opposite of
> V4L/DRM FourCCs). This covers most practical cases, e.g. %p4cn would
> allow printing LSByte-first FourCCs stored in host endian order
> (other than the hex form being in character order, not the integer
> value).
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Hector Martin <marcan@...can.st>
> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
> —

FWIW, Rasmus had acked this patch in my v3 submission [1] , I forgot to put it. So,

Acked-by: Rasmus Villemoes <linux@...musvillemoes.dk>

[1] https://lore.kernel.org/asahi/CAKwiHFi_nngthth0wZkaPviVeS+8SWDtTw6gJcDAHCqiwXAG2A@mail.gmail.com/