linux-kernel - Re: [PATCH v5 5/9] gpio: aggregator: add 'name' attribute for custom GPIO line names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m3a6hcsh2a3j3rcw7x2f3tn3gif6mtor7bfxdmwkgp435vmxpg@upgh5b2t3ukh>
Date: Wed, 5 Mar 2025 21:44:47 +0900
From: Koichiro Den <koichiro.den@...onical.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-gpio@...r.kernel.org, geert+renesas@...der.be, 
	linus.walleij@...aro.org, maciej.borzecki@...onical.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/9] gpio: aggregator: add 'name' attribute for custom
 GPIO line names

On Thu, Feb 27, 2025 at 10:50:34AM GMT, Bartosz Golaszewski wrote:
> On Mon, Feb 24, 2025 at 3:32 PM Koichiro Den <koichiro.den@...onical.com> wrote:
> >
> > Previously, there was no way to assign names to GPIO lines exported
> > through the aggregator when the device was created via sysfs.
> >
> > Allow users to set custom line names via a 'name' attribute and
> > expose them using swnode.
> >
> > Signed-off-by: Koichiro Den <koichiro.den@...onical.com>
> > ---
> 
> IMO this should be part of the previous commit, there's no reason to
> split the configfs implementation. But only change that if there'll be
> a v6, otherwise I'll take it as is.

Honestly, I held off replying here, hoping to get some input on:
https://lore.kernel.org/all/CAMRc=MegKxwX-RjQQcWMGe_JQyRCv82WRRbD0naYkeXshTGXGQ@mail.gmail.com/
since I thought the decision on sending v6 might depend on the feedback.
Anyhow, thank you for reviewing.

Koichiro

> 
> Bart