linux-kernel - Re: [PATCH v7 2/3] ttynull: Add an option to allow ttynull to be used as a console device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4217265.X513TT2pbd@nerdopolis2>
Date: Thu, 06 Mar 2025 08:41:09 -0500
From: Adam Simonelli <adamsimonelli@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jiri Slaby <jirislaby@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Steven Rostedt <rostedt@...dmis.org>,
 John Ogness <john.ogness@...utronix.de>,
 Sergey Senozhatsky <senozhatsky@...omium.org>, Petr Mladek <pmladek@...e.com>
Subject:
 Re: [PATCH v7 2/3] ttynull: Add an option to allow ttynull to be used as a
 console device

On Thursday, March 6, 2025 2:06:14 AM EST Andy Shevchenko wrote:
> On Thu, Mar 6, 2025 at 3:30 AM Adam Simonelli <adamsimonelli@...il.com> wrote:
> > On Wednesday, March 5, 2025 2:18:39 PM EST Andy Shevchenko wrote:
> > > On Wed, Mar 5, 2025 at 6:30 AM <adamsimonelli@...il.com> wrote:
> 
> ...
> 
> > > >           In order to use this driver, you should redirect the console to this
> > > > -         TTY, or boot the kernel with console=ttynull.
> > > > +         TTY, boot the kernel with console=ttynull, or enable
> > > > +         CONFIG_NULL_TTY_DEFAULT_CONSOLE.
> > >
> > > I haven't checked what it looks like in menuconfig / nconfig / etc,
> > > but I think that CONFIG_ is redundant here.
> > >
> > OK, I didn't know what one is more typical. Doing a loose grep for
> > "^<tab><space><space>" and "[A-Z]_[A-Z]" (excluding CONFIG_) seems like there
> > are more help text lines that mention other config options (~622) than include
> > the CONFIG (174). I will change it
> 
> Thanks, it's better to follow the common practices.
> 
> > > > +         If unsure, say N.
> > > > +
> > > > +config NULL_TTY_DEFAULT_CONSOLE
> > > > +       bool "Support for console on ttynull"
> > > > +       depends on NULL_TTY=y && !VT_CONSOLE
> > > > +       help
> > > > +         Say Y here if you want the NULL TTY to be used as a /dev/console
> > > > +         device.
> > > > +
> > > > +         This is similar to CONFIG_VT_CONSOLE, but without the dependency on
> > > > +         CONFIG_VT. It uses the ttynull driver as the system console.
> > >
> > > Btw, do those `make nconfig` and friends render the options?
> > Seems like `make nconfig` works, as well as `make xconfig` I will attempt to
> > attach a png screenshot.
> 
> Thanks. Have you checked the search? I believe it should work with and
> without CONFIG_ in the same way.
> 
> > > >           If unsure, say N.
> 
> 
Yeah, it shows up if I search NULL_TTY_DEFAULT_CONSOLE