linux-kernel - Re: [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk directly connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d769d82-e429-6e25-8bb5-97ef5c2e7a62@huawei.com>
Date: Thu, 6 Mar 2025 09:44:23 +0800
From: yangxingui <yangxingui@...wei.com>
To: John Garry <john.g.garry@...cle.com>, <liyihang9@...wei.com>,
	<yanaijie@...wei.com>
CC: <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linuxarm@...wei.com>, <prime.zeng@...wei.com>, <liuyonglong@...wei.com>,
	<kangfenglong@...wei.com>, <liyangyang20@...wei.com>,
	<f.fangjian@...wei.com>, <xiabing14@...artners.com>
Subject: Re: [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk
 directly connected


Hi, John

On 2025/3/6 0:15, John Garry wrote:
> On 05/03/2025 08:16, yangxingui wrote:
>>>
>>> Sure, something like that - you just need to get libsas to trigger 
>>> the proper hw port id assignment for the device. As for specific 
>>> implementation in the LLDD, that up to you guys.
>>
>> Thank you for your suggestions. The disk was finally restored to 
>> normal, but the error handling took a long time. Since the error 
>> handling would set the host to the recovery state, other disks on the 
>> same host would be blocked for a long time.
> 
> But that because you have IO inflight for the disk which was unplugged?

No, these are all ATA_CMD_ID_ATA commands newly issued by 
ata_eh_revalidate_and_attach() during error handling, and will be 
retried three times. The reason is that after the hw port id is changed, 
we set it to invalid, and these ATA_CMD_ID_ATA cmds will fail to execute.

Thanks,
Xingui