linux-kernel - Re: [PATCH] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d98ad83e-6479-4453-bd1d-4f3703b0dad2@tuxedocomputers.com>
Date: Thu, 6 Mar 2025 14:56:09 +0100
From: Georg Gottleuber <g.gottleuber@...edocomputers.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Georg Gottleuber <ggo@...edocomputers.com>,
 Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Konrad Dybcio
 <konrad.dybcio@....qualcomm.com>, wse@...edocomputers.com,
 cs@...edocomputers.com
Subject: Re: [PATCH] arm64: dts: qcom: Add device tree for TUXEDO Elite 14
 Gen1



Am 06.03.25 um 13:41 schrieb Krzysztof Kozlowski:
...
> 
> Please run scripts/checkpatch.pl and fix reported warnings. After that,
> run also `scripts/checkpatch.pl --strict` and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in touch
> if the warning is not clear.
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.

Thank you for the advice and the offer to answer further questions.
Didn't know that dtb_check exists.

> ...
> 
>> +
>> +       eusb3_repeater: redriver@47 {
>> +               compatible = "nxp,ptn3222";
>> +               reg = <0x47>;
>> +               #phy-cells = <0>;
>> +
>> +               vdd1v8-supply = <&vreg_l4b_1p8>;
>> +               vdd3v3-supply = <&vreg_l13b_3p0>;
>> +
>> +               reset-gpios = <&tlmm 124 GPIO_ACTIVE_LOW>;
>> +
>> +               pinctrl-0 = <&eusb3_reset_n>;
>> +               pinctrl-names = "default";
> 
> No graph? Isn't it needed?

What do you mean by ‘no graph’?

>> +       };
>> +
>> +       eusb5_repeater: redriver@43 {
>> +               compatible = "nxp,ptn3222";
>> +               reg = <0x43>;
>> +               #phy-cells = <0>;
>> +
>> +               vdd1v8-supply = <&vreg_l4b_1p8>;
>> +               vdd3v3-supply = <&vreg_l13b_3p0>;
>> +
>> +               reset-gpios = <&tlmm 184 GPIO_ACTIVE_LOW>;
>> +
>> +               pinctrl-0 = <&eusb6_reset_n>;
>> +               pinctrl-names = "default";
>> +       };
>> +
>> +       eusb6_repeater: redriver@4f {
>> +               compatible = "nxp,ptn3222";
>> +               reg = <0x4f>;
>> +               #phy-cells = <0>;
>> +
>> +               vdd1v8-supply = <&vreg_l4b_1p8>;
>> +               vdd3v3-supply = <&vreg_l13b_3p0>;
>> +
>> +               reset-gpios = <&tlmm 111 GPIO_ACTIVE_LOW>;
>> +
>> +               pinctrl-0 = <&eusb6_reset_n>;
>> +               pinctrl-names = "default";
>> +       };
>> +
> 
> Stray blank line

Sorry. Will fix this.

>> +};
>> +
>> +&mdss {
>> +       status = "okay";
>> +};
>> +
> 
> 
>> +
>> +&usb_1_ss0_dwc3_hs {
>> +       remote-endpoint = <&pmic_glink_ss0_hs_in>;
>> +};
>> +
>> +&usb_1_ss0_qmpphy_out {
>> +       remote-endpoint = <&pmic_glink_ss0_ss_in>;
>> +};
>> +
> 
> Here as well

Same here.

Regards,
Georg