linux-kernel - Re: [PATCH v5 5/5] gpu: nova-core: add initial documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250306.225902.541492197262171384.fujita.tomonori@gmail.com>
Date: Thu, 06 Mar 2025 22:59:02 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: dakr@...nel.org
Cc: fujita.tomonori@...il.com, airlied@...il.com, simona@...ll.ch,
 corbet@....net, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, ajanulgu@...hat.com, lyude@...hat.com,
 pstanner@...hat.com, zhiw@...dia.com, cjia@...dia.com,
 jhubbard@...dia.com, bskeggs@...dia.com, acurrid@...dia.com,
 ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
 gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me,
 a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
 gregkh@...uxfoundation.org, mcgrof@...nel.org, russ.weight@...ux.dev,
 dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, nouveau@...ts.freedesktop.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v5 5/5] gpu: nova-core: add initial documentation

On Thu, 6 Mar 2025 14:45:05 +0100
Danilo Krummrich <dakr@...nel.org> wrote:

> On Thu, Mar 06, 2025 at 09:56:38PM +0900, FUJITA Tomonori wrote:
>> On Tue,  4 Mar 2025 18:34:52 +0100
>> Danilo Krummrich <dakr@...nel.org> wrote:
>> 
>> > +Delay / Sleep abstractions
>> > +--------------------------
>> > +
>> > +Rust abstractions for the kernel's delay() and sleep() functions.
>> > +
>> > +There is some ongoing work from FUJITA Tomonori [1], which has not seen any updates
>> > +since Oct. 24.
>> > +
>> > +| Complexity: Beginner
>> > +| Link: https://lore.kernel.org/netdev/20241001112512.4861-2-fujita.tomonori@gmail.com/ [1]
>> 
>> I posted v11 last month.
>> 
>> https://lore.kernel.org/netdev/20250220070611.214262-1-fujita.tomonori@gmail.com/
> 
> Thanks for letting me know.
> 
> I think I lost track of this because in v1 the series was named "add delay
> abstraction (sleep functions)" and with v2 it was switched to "rust: Add IO
> polling" and I was searching for subsequent patch series with the "delay"
> keyword.

I see.

During the review process, I changed the subject due to the consensus
that, in most cases, device drivers should use read_poll_timeout
instead of calling the sleep function directly.

> Anyways, AFAICS you ended up with adding fsleep(). I think nova-core will need
> control over having a busy loop or actually re-schedule.

I plan to add read_poll_timeout_atomic() with delay functions:

https://lore.kernel.org/netdev/20250228.080550.354359820929821928.fujita.tomonori@gmail.com/

delay functions need Delta struct in the patchset so the patchset
needs to be merged first.