linux-kernel - Re: [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afe1589b-81dc-488e-95ee-ce617213cbd1@linaro.org>
Date: Thu, 6 Mar 2025 15:01:31 +0100
From: neil.armstrong@...aro.org
To: Charles Han <hanchunchao@...pur.com>, andrzej.hajda@...el.com,
 rfoss@...nel.org, Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 festevam@...x.de
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting
 warning

On 05/03/2025 11:35, Charles Han wrote:
> Fix below inconsistent indenting smatch warning.
> smatch warnings:
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
> 
> Signed-off-by: Charles Han <hanchunchao@...pur.com>
> ---
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index 9549dabde941..9d5bded54e8b 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -333,9 +333,9 @@ static int dw_hdmi_cec_suspend(struct device *dev)
>   	struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>   
>   	/* store interrupt status/mask registers */
> -	 cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> -	 cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> -	 cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
> +	cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> +	cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> +	cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>   
>   	return 0;
>   }

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>