linux-kernel - Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250306015901.241800-1-trintaeoitogc@gmail.com>
Date: Wed,  5 Mar 2025 22:59:01 -0300
From: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
To: miguel.ojeda.sandonis@...il.com
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	aliceryhl@...gle.com,
	apw@...onical.com,
	arnd@...db.de,
	aswinunni01@...il.com,
	axboe@...nel.dk,
	benno.lossin@...ton.me,
	bhelgaas@...gle.com,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	dakr@...nel.org,
	dwaipayanray1@...il.com,
	ethan.twardy@...il.com,
	fujita.tomonori@...il.com,
	gary@...yguo.net,
	gregkh@...uxfoundation.org,
	joe@...ches.com,
	linux-kernel@...r.kernel.org,
	lukas.bulwahn@...il.com,
	ojeda@...nel.org,
	pbonzini@...hat.com,
	rust-for-linux@...r.kernel.org,
	tmgross@...ch.edu,
	trintaeoitogc@...il.com,
	walmeida@...rosoft.com
Subject: Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:
> No, Andreas means a script written in Rust, rather than a binary that
> comes from the toolchain.
> 
> I think it could be a good idea (it would be lovely to write the
> checker in Rust -- I also had a checker bot in Python from the old
> days of the old `rust` branch in GitHub), but `checkpatch.pl` doesn't
> need a built kernel, so it would be a disadvantage or at least a
> difference w.r.t. the usual `checkpatch.pl`, and we may not be able to
> call it from `checkpatch.pl`.
I don't know if I really understand how this would is do.

> Did you check? i.e. is it something we noticed, or something that
> generally happens but maybe not in this case? Is there a way to
> workaround or disable that (e.g. a `rustfmt` config value)?
The rustfmt have a array_width parameter [1], but with this, all arrays in rust
code will have the formatting that we set. (In this case, is 1 per line).

If we set the max_width, for limit the width of line, it seens for me, that
arrays don't are affected.

[1] https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#array_width

Thanks,
Guilherme