linux-kernel - Re: [PATCH] nvme: remove multipath module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250306151654.GA22810@lst.de>
Date: Thu, 6 Mar 2025 16:16:54 +0100
From: Christoph Hellwig <hch@....de>
To: Keith Busch <kbusch@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Sagi Grimberg <sagi@...mberg.me>,
	Nilay Shroff <nilay@...ux.ibm.com>,
	John Meneghini <jmeneghi@...hat.com>, bmarzins@...hat.com,
	Bryan Gurney <bgurney@...hat.com>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Marco Patalano <mpatalan@...hat.com>,
	axboe@...nel.dk
Subject: Re: [PATCH] nvme: remove multipath module parameter

On Thu, Mar 06, 2025 at 08:01:19AM -0700, Keith Busch wrote:
> > If the device is indeed entirely single ported and Samsung can confirm
> > the setting is incorret and not easily fixable by a firmware update
> > we can quirk it.
> 
> It's not one vendor or device.

I've not seen in in the wild so it can't be that common.

> Or consider a true multiport PCIe where each port connects to a
> different host. Each host sees a single port so they're not using
> multipath capabilities, and the admin wants the MD behavior that removes
> a disk on hot plug. Or even if one host sees both paths of a multiport
> PCIe, they still might want that hot plug behavior. The module parameter
> makes that possible, so some equivalent should be available before
> removing it.

A module-wide parameter is absolutely the wrong way to configure it.
You'd ad best want it per-controller or even per-namespace.  One
tradeoff would be to disable the multipath code for private namespaces,
although that would cause problems when rescanning changes the flag.