linux-kernel - Re: [PATCH resend ] tracepoint: Print the function symbol when tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <070e4579-bbe3-48ef-9e60-1daf51df4b78@amperemail.onmicrosoft.com>
Date: Thu, 6 Mar 2025 10:26:35 +0800
From: Shijie Huang <shijie@...eremail.onmicrosoft.com>
To: Steven Rostedt <rostedt@...dmis.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Huang Shijie <shijie@...amperecomputing.com>,
 patches@...erecomputing.com, cl@...ux.com, yang@...amperecomputing.com,
 peterz@...radead.org, jpoimboe@...nel.org, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH resend ] tracepoint: Print the function symbol when
 tracepoint_debug is set


On 2025/3/5 23:47, Steven Rostedt wrote:
> On Wed, 5 Mar 2025 08:53:43 -0500
> Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
>
>> On 2025-03-04 20:55, Huang Shijie wrote:
>>> When tracepoint_debug is set, we may get the output in kernel log:
>>>        [  380.013843] Probe 0 : 00000000f0d68cda
>>>
>>> It is not readable, so change to print the function symbol.
>>> After this patch, the output may becomes:
>>>        [   54.930567] Probe 0 : perf_trace_sched_wakeup_template
>> What would it print if the address is corrupted ?
>>
>> Perhaps we could do like the backtrace code and print e.g.
>>
>> [<00000000f0d68cda>] perf_trace_sched_wakeup_template+0xNN/0xMM
>>
>> ?
>>
>> I don't care about the actual layout, but removing the address
>> from the formatted output appears to be removing useful data
>> in debug situations.
>>
> Perhaps this can use "%pS" which shows both the function entry and the

okay, I can change it to use "%pS" in next version if we think it is 
good enough:

      [   55.225555] Probe 0 : perf_trace_sched_wakeup_template+0x0/0x20


Thanks

Huang Shijie