linux-kernel - Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f5da931-081a-4859-8833-655a5b5a3b9d@collabora.com>
Date: Thu, 6 Mar 2025 19:24:25 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Heiko Stübner <heiko@...ech.de>,
 Shreeya Patel <shreeya.patel@...labora.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil
 <hverkuil@...all.nl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, jose.abreu@...opsys.com, nelson.costa@...opsys.com,
 shawn.wen@...k-chips.com, nicolas.dufresne@...labora.com,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: kernel@...labora.com, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, Tim Surber <me@...surber.de>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Diederik de Haas <didi.debian@...ow.org>
Subject: Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for
 HDMI RX Controller

On 3/6/25 19:16, Heiko Stübner wrote:
>>>> +		pinctrl-0 = <&hdmim1_rx>;
>>>> +		pinctrl-names = "default";
>>> hmm, this might be better living in the board dts?
>> HDMI RX controller is a part of the SoC, it's not specific to a
>> particular board. If you meaning move it into rock5b.dts, then we
>> definitely shouldn't do it. It's like moving PCIe controller node into a
>> board DT 🙂
> sorry, should've been clearer. I meant the pinctrl.
> There are two sets of pins hdmim0-rx and hdmim1-rx which one is used is
> board specific.
> 
> Can you check if "most" boards use the M1 variant?
> 
> Rationale being, that if we know that most boards use the same set of
> pins, it's likely ok to just have the minority boards override it.

Will check, thanks for the clarification!

-- 
Best regards,
Dmitry