linux-kernel - Re: [PATCH] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jxld7w4i7nut35pnmaxgsnmccg3efffas3rubouxcpxbxrrrxh@rrl47w24ju3i>
Date: Thu, 6 Mar 2025 18:45:57 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Georg Gottleuber <g.gottleuber@...edocomputers.com>, 
	Georg Gottleuber <ggo@...edocomputers.com>, Bjorn Andersson <andersson@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	wse@...edocomputers.com, cs@...edocomputers.com
Subject: Re: [PATCH] arm64: dts: qcom: Add device tree for TUXEDO Elite 14
 Gen1

On Thu, Mar 06, 2025 at 03:03:32PM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2025 14:56, Georg Gottleuber wrote:
> > 
> >> ...
> >>
> >>> +
> >>> +       eusb3_repeater: redriver@47 {
> >>> +               compatible = "nxp,ptn3222";
> >>> +               reg = <0x47>;
> >>> +               #phy-cells = <0>;
> >>> +
> >>> +               vdd1v8-supply = <&vreg_l4b_1p8>;
> >>> +               vdd3v3-supply = <&vreg_l13b_3p0>;
> >>> +
> >>> +               reset-gpios = <&tlmm 124 GPIO_ACTIVE_LOW>;
> >>> +
> >>> +               pinctrl-0 = <&eusb3_reset_n>;
> >>> +               pinctrl-names = "default";
> >>
> >> No graph? Isn't it needed?
> > 
> > What do you mean by ‘no graph’?
> 
> ports connecting this within USB graph between controller and connector.
> Just like other devices with redriver.

No, eUSB2 redrivers don't need (and don't use) OF graph, they are
basic PHYs. See Documentation/devicetree/bindings/phy/nxp,ptn3222.yaml

So this one is correct.

-- 
With best wishes
Dmitry