linux-kernel - Re: [PATCH v2 2/5] tools/nolibc: always use openat(2) instead of open(2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac0e325b-4882-4c23-8507-cef3b86d3469@t-8ch.de>
Date: Thu, 6 Mar 2025 17:56:12 +0100
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Louis Taylor <louis@...gniz.eu>
Cc: Willy Tarreau <w@....eu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] tools/nolibc: always use openat(2) instead of
 open(2)

On 2025-03-04 07:58:16+0000, Louis Taylor wrote:
> All architectures support openat, so we don't need to make its use
> conditional.
> 
> Signed-off-by: Louis Taylor <louis@...gniz.eu>
> ---
>  tools/include/nolibc/sys.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tools/include/nolibc/sys.h b/tools/include/nolibc/sys.h
> index 3cd938f9abda..a8dca5ac6542 100644
> --- a/tools/include/nolibc/sys.h
> +++ b/tools/include/nolibc/sys.h
> @@ -798,13 +798,7 @@ int openat(int dirfd, const char *path, int flags, ...)
>  static __attribute__((unused))
>  int sys_open(const char *path, int flags, mode_t mode)
>  {
> -#ifdef __NR_openat
>  	return my_syscall4(__NR_openat, AT_FDCWD, path, flags, mode);
> -#elif defined(__NR_open)
> -	return my_syscall3(__NR_open, path, flags, mode);
> -#else
> -	return __nolibc_enosys(__func__, path, flags, mode);
> -#endif

Linus at some point was unhappy with usage of the *at() system calls
over the regular ones for perfomance reasons.
But that probably doesn't matter for nolibc and we are preferring
openat() anyways.

So:

Acked-by: Thomas Weißschuh <linux@...ssschuh.net>

>  }
>  
>  static __attribute__((unused))
> -- 
> 2.45.2
>