linux-kernel - Re: [PATCH v4 9/8] iio: adc: ad7124: Benefit of dev = indio_dev->dev.parent in ad7124_parse_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250306001013.7cd5d00c@jic23-huawei>
Date: Thu, 6 Mar 2025 00:10:13 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>, Cosmin Tanislav
 <cosmin.tanislav@...log.com>, Dumitru Ceclan <mitrutzceclan@...il.com>,
 Guillaume Ranquet <granquet@...libre.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
 Michael Walle <michael@...le.cc>, Nuno Sa <nuno.sa@...log.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 9/8] iio: adc: ad7124: Benefit of dev =
 indio_dev->dev.parent in ad7124_parse_channel_config()

On Tue, 4 Mar 2025 10:41:09 +0100
Uwe Kleine-König <u.kleine-koenig@...libre.com> wrote:

> Since commit a6eaf02b8274 ("iio: adc: ad7124: Switch from of specific to
> fwnode based property handling") the function
> ad7124_parse_channel_config() has a parameter `dev` that holds
> the value `indio_dev->dev.parent`. Make use of that to shorten two code
> lines.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
> Hello,
> 
> this is a patch opportunity I noticed while backporting my original
> series to an older kernel to please my customer.
> I chose to sneak it into the series in the hope to not offend maintainer
> tools :-)
Leads to b4 getting rather confused, but doing the right thing in the end.

Applied.

Thanks,

Jonathan

> 
> Best regards
> Uwe
> 
>  drivers/iio/adc/ad7124.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 5ab0d3e48c43..53b274ca42ac 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -1061,12 +1061,12 @@ static int ad7124_parse_channel_config(struct iio_dev *indio_dev,
>  	/* Add one for temperature */
>  	st->num_channels = min(num_channels + 1, AD7124_MAX_CHANNELS);
>  
> -	chan = devm_kcalloc(indio_dev->dev.parent, st->num_channels,
> +	chan = devm_kcalloc(dev, st->num_channels,
>  			    sizeof(*chan), GFP_KERNEL);
>  	if (!chan)
>  		return -ENOMEM;
>  
> -	channels = devm_kcalloc(indio_dev->dev.parent, st->num_channels, sizeof(*channels),
> +	channels = devm_kcalloc(dev, st->num_channels, sizeof(*channels),
>  				GFP_KERNEL);
>  	if (!channels)
>  		return -ENOMEM;