linux-kernel - Re: [PATCH] m68k: mm: Remove size argument when calling strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a968b291-63ed-4913-821d-16408c528876@yoseli.org>
Date: Thu, 6 Mar 2025 18:41:11 +0100
From: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: mm: Remove size argument when calling strscpy()

Hi Thorsten,

Thanks for the patch !

On 03/03/2025 00:05, Thorsten Blum wrote:
> The size parameter of strscpy() is optional and specifying the size of
> the destination buffer is unnecessary. Remove it to simplify the code.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Tested-by: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>

> ---
>   arch/m68k/kernel/setup_mm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
> index 48ce67947678..0fba32552836 100644
> --- a/arch/m68k/kernel/setup_mm.c
> +++ b/arch/m68k/kernel/setup_mm.c
> @@ -147,8 +147,7 @@ static void __init m68k_parse_bootinfo(const struct bi_record *record)
>   			break;
>   
>   		case BI_COMMAND_LINE:
> -			strscpy(m68k_command_line, data,
> -				sizeof(m68k_command_line));
> +			strscpy(m68k_command_line, data);
>   			break;
>   
>   		case BI_RNG_SEED: {