linux-kernel - Re: [PATCH net v1] netmem: prevent TX of unreadable skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250305191153.6d899a00@kernel.org>
Date: Wed, 5 Mar 2025 19:11:53 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 stable@...r.kernel.org
Subject: Re: [PATCH net v1] netmem: prevent TX of unreadable skbs

On Tue,  4 Mar 2025 23:49:24 +0000 Mina Almasry wrote:
> @@ -3914,6 +3914,9 @@ static struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device
>  
>  	skb = validate_xmit_xfrm(skb, features, again);
>  
> +	if (!skb_frags_readable(skb))
> +		goto out_kfree_skb;

I'd put this new check at the beginning rather than the end.
Feeding unreadable packets into GSO will not result in
much happiness.