linux-kernel - Re: [PATCH] staging: sm750fb: Fix CamelCase variable naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <635f849e14854b0db1f53a0d0bf329c3070e5859.camel@gmail.com>
Date: Thu, 06 Mar 2025 16:40:05 -0300
From: Gabriel Lima Luz <lima.gabriel.luz@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev, 
 linux-kernel@...r.kernel.org, Sudip Mukherjee <sudipm.mukherjee@...il.com>,
  Teddy Wang <teddy.wang@...iconmotion.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  ~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH] staging: sm750fb: Fix CamelCase variable naming

Em sex, 2025-02-28 às 20:40 +0300, Dan Carpenter escreveu:
> On Fri, Feb 28, 2025 at 01:23:54PM -0300, Gabriel Lima Luz wrote:
> > Adhere to Linux kernel coding style.
> > 
> > Reported by checkpatch:
> > 
> > CHECK: Avoid CamelCase
> > 
> > Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@...il.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_power.h | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/sm750fb/ddk750_power.h
> > b/drivers/staging/sm750fb/ddk750_power.h
> > index 63c9e8b6ffb3..33e852fe6949 100644
> > --- a/drivers/staging/sm750fb/ddk750_power.h
> > +++ b/drivers/staging/sm750fb/ddk750_power.h
> > @@ -3,10 +3,10 @@
> >  #define DDK750_POWER_H__
> >  
> >  enum dpms {
> > -	crtDPMS_ON = 0x0,
> > -	crtDPMS_STANDBY = 0x1,
> > -	crtDPMS_SUSPEND = 0x2,
> > -	crtDPMS_OFF = 0x3,
> > +	crt_DPMS_ON = 0x0,
> > +	crt_DPMS_STANDBY = 0x1,
> > +	crt_DPMS_SUSPEND = 0x2,
> > +	crt_DPMS_OFF = 0x3,
> >  };
> >  
> 
> It seems these are not used.  Just delete them.
> 
> regards,
> dan carpenter
> 
The dpms enum is used in the definition of the 
ddk750_set_dpms function in ddk750_power.h file and
this function is called in ddk750_display.c on line 158.

If I were to delete it, what changes should I make to 
the function mentioned above ? 

this is my first contribution, thanks for all the help.

best regards,
Gabriel Lima