[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250306-mt8188-accdet-v3-0-7828e835ff4b@collabora.com>
Date: Thu, 06 Mar 2025 16:52:14 -0300
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Trevor Wu <trevor.wu@...iatek.com>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>
Cc: kernel@...labora.com, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
Nícolas F. R. A. Prado <nfraprado@...labora.com>,
Zoran Zhan <zoran.zhan@...iatek.com>
Subject: [PATCH v3 0/4] Allow retrieving accessory detection reference on
MT8188
This series enables the MT8188-MT6359 sound driver to retrieve the
MT6359 ACCDET sound component from a mediatek,accdet DT property, which
allows detecting jack insertion/removal.
Patch 1 describes the new property in the binding. Patch 2 implements
the sound component retrieval in the common MTK soundcard driver. Patch
4 updates the MT8188-MT6359 sound driver to register the audio jack and
initialize the ACCDET driver for detection, if the property is present.
Patch 3 adds a stub to prevent a linker failure in case the
MT6359-ACCDET config is disabled.
Tested on the Genio 700 EVK board.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
---
Changes in v3:
- Removed the config select for CONFIG_SND_SOC_MT6359_ACCDET
- Added patch 3 with stub for mt6359_accdet_enable_jack_detect()
- Fixed return checks for mediatek,accdet handling to check for non-null
rather than !IS_ERR(), and added error messages
- Link to v2: https://lore.kernel.org/r/20250304-mt8188-accdet-v2-0-27f496c4aede@collabora.com
Changes in v2:
- Added CONFIG_SND_SOC_MT6359_ACCDET select in
CONFIG_SND_SOC_MT8188_MT6359 to avoid build failure
- Clarified in mediatek,accdet dt-binding and commit description that
the property should only be present if the accdet is actually used
- Link to v1: https://lore.kernel.org/r/20250214-mt8188-accdet-v1-0-6bbd5483855b@collabora.com
---
Nícolas F. R. A. Prado (4):
ASoC: dt-bindings: mediatek,mt8188-mt6359: Add mediatek,accdet
ASoC: mediatek: common: Handle mediatek,accdet property
ASoC: mediatek: mt6359: Add stub for mt6359_accdet_enable_jack_detect
ASoC: mediatek: mt8188-mt6359: Add accdet headset jack detect support
.../bindings/sound/mediatek,mt8188-mt6359.yaml | 8 ++++
sound/soc/codecs/mt6359-accdet.h | 9 +++++
sound/soc/mediatek/common/mtk-soc-card.h | 1 +
sound/soc/mediatek/common/mtk-soundcard-driver.c | 19 +++++++++-
sound/soc/mediatek/mt8188/mt8188-mt6359.c | 43 ++++++++++++++++++++++
5 files changed, 79 insertions(+), 1 deletion(-)
---
base-commit: 565351ae7e0cee80e9b5ed84452a5b13644ffc4d
change-id: 20250214-mt8188-accdet-4deabb85534d
Best regards,
--
Nícolas F. R. A. Prado <nfraprado@...labora.com>
Powered by blists - more mailing lists