linux-kernel - [PATCH] stop-machine: Add comment for rcu_momentary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9d3f4116-db64-43fb-85f1-0b939038206e@paulmck-laptop>
Date: Thu, 6 Mar 2025 12:00:02 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: linux-kernel@...r.kernel.org
Cc: tglx@...utronix.de, vschneid@...hat.com, neeraj.upadhyay@...nel.org,
	frederic@...nel.org, kernel-team@...a.com
Subject: [PATCH] stop-machine: Add comment for rcu_momentary_eqs()

Add a comment to explain the purpose of the rcu_momentary_eqs() call
from multi_cpu_stop(), which is to suppress false-positive RCU CPU
stall warnings.

Reported-by: Thomas Gleixner <tglx@...utronix.de>
Link: https://lore.kernel.org/all/87wmeuanti.ffs@tglx/
Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
Cc: Valentin Schneider <vschneid@...hat.com>
Cc: Neeraj Upadhyay <neeraj.upadhyay@...nel.org>
Cc: Frederic Weisbecker <frederic@...nel.org>
---
 stop_machine.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
index 8896d844d738f..5d2d0562115b3 100644
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -250,6 +250,7 @@ static int multi_cpu_stop(void *data)
 			 * be detected and reported on their side.
 			 */
 			touch_nmi_watchdog();
+			/* Also suppress RCU CPU stall warnings. */
 			rcu_momentary_eqs();
 		}
 	} while (curstate != MULTI_STOP_EXIT);