linux-kernel - Re: [PATCH net-next 12/14] net: bcmgenet: move bcmgenet_power_up into resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c147d3d5-863b-4c57-b861-687a927792b0@broadcom.com>
Date: Thu, 6 Mar 2025 12:24:50 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Doug Berger <opendmb@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 12/14] net: bcmgenet: move bcmgenet_power_up into
 resume_noirq

On 3/6/25 11:26, Doug Berger wrote:
> The bcmgenet_power_up() function is moved from the resume method
> to the resume_noirq method for symmetry with the suspend_noirq
> method. This allows the wol_active flag to be removed.
> 
> The UMAC_IRQ_WAKE_EVENT interrupts that can be unmasked by the
> bcmgenet_wol_power_down_cfg() function are now re-masked by the
> bcmgenet_wol_power_up_cfg() function at the resume_noirq level
> as well.
> 
> Signed-off-by: Doug Berger <opendmb@...il.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian