linux-kernel - Re: [PATCH net-next 14/14] net: bcmgenet: revise suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e85b182a-ce69-4303-b401-a646139edb8d@broadcom.com>
Date: Thu, 6 Mar 2025 12:29:12 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Doug Berger <opendmb@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 14/14] net: bcmgenet: revise suspend/resume

On 3/6/25 11:26, Doug Berger wrote:
> If the network interface is configured for Wake-on-LAN we should
> avoid bringing the interface down and up since it slows the time
> to reestablish network traffic on resume.
> 
> Redundant calls to phy_suspend() and phy_resume() are removed
> since they are already invoked from within phy_stop() and
> phy_start() called from bcmgenet_netif_stop() and
> bcmgenet_netif_start().
> 
> Signed-off-by: Doug Berger <opendmb@...il.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian