linux-kernel - Re: [PATCH v3 2/4] pinctrl: samsung: add dedicated SoC eint suspend/resume callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1418fde488646160a1be14b2153e409488f3d861.camel@linaro.org>
Date: Thu, 06 Mar 2025 21:15:19 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Peter Griffin <peter.griffin@...aro.org>, Krzysztof Kozlowski	
 <krzk@...nel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, Alim Akhtar
	 <alim.akhtar@...sung.com>, Linus Walleij <linus.walleij@...aro.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	tudor.ambarus@...aro.org, willmcvicker@...gle.com,
 semen.protsenko@...aro.org, 	kernel-team@...roid.com,
 jaewon02.kim@...sung.com
Subject: Re: [PATCH v3 2/4] pinctrl: samsung: add dedicated SoC eint
 suspend/resume callbacks

On Thu, 2025-03-06 at 20:42 +0000, Peter Griffin wrote:
> gs101 needs it's own suspend/resume callbacks to use the newly
> added eint_fltcon_offset for saving & restoring fltcon0 & fltcon1
> registers. It also differs to previous SoCs in that fltcon1
> register doesn't always exist for each bank.
> 
> exynosautov920 also has dedicated logic for using eint_con_offset
> and eint_mask_offset for saving & restoring it's registers.
> 
> Refactor the existing platform specific suspend/resume callback
> so that each SoC variant has their own callback containing the
> SoC specific logic.
> 
> Additionally we now call drvdata->suspend() & drvdata->resume()
> from within the loop that iterates the banks in
> samsung_pinctrl_suspend() and samsung_pinctrl_resume().
> 
> This simplifies the logic, and allows us to remove the
> clk_enable() and clk_disable() from the callbacks.
> 
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> ---
> Changes since v2:
> * Remove useless init (Andre)
> * make it clear set_wakeup is conditional on bank->eint_type (Andre)
> 
> Changes since v1:
> * Split code refactor & gs101 parts into separate patches (Andre)
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos-arm64.c |  28 ++--
>  drivers/pinctrl/samsung/pinctrl-exynos.c       | 201 ++++++++++---------------
>  drivers/pinctrl/samsung/pinctrl-exynos.h       |   6 +-
>  drivers/pinctrl/samsung/pinctrl-samsung.c      |  11 +-
>  drivers/pinctrl/samsung/pinctrl-samsung.h      |   8 +-
>  5 files changed, 109 insertions(+), 145 deletions(-)

Reviewed-by: André Draszik <andre.draszik@...aro.org>