linux-kernel - Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ca55233-b370-4176-9632-8e5df8d4c4ce@roeck-us.net>
Date: Wed, 5 Mar 2025 16:00:48 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Andy Shevchenko <andy@...nel.org>,
 George Cherian <george.cherian@...vell.com>
Cc: wim@...ux-watchdog.org, jwerner@...omium.org, evanbenn@...omium.org,
 kabel@...nel.org, krzk@...nel.org, mazziesaccount@...il.com,
 thomas.richard@...tlin.com, lma@...omium.org, bleung@...omium.org,
 support.opensource@...semi.com, shawnguo@...nel.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, festevam@...il.com, paul@...pouillou.net,
 alexander.usyskin@...el.com, andreas.werner@....de, daniel@...ngy.jp,
 romain.perier@...il.com, avifishman70@...il.com, tmaimon77@...il.com,
 tali.perry1@...il.com, venture@...gle.com, yuenn@...gle.com,
 benjaminfair@...gle.com, maddy@...ux.ibm.com, mpe@...erman.id.au,
 npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org,
 mwalle@...nel.org, xingyu.wu@...rfivetech.com, ziv.xu@...rfivetech.com,
 hayashi.kunihiko@...ionext.com, mhiramat@...nel.org,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, chrome-platform@...ts.linux.dev,
 imx@...ts.linux.dev, linux-mips@...r.kernel.org, openbmc@...ts.ozlabs.org,
 linuxppc-dev@...ts.ozlabs.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier
 callback

On 3/5/25 02:33, Andy Shevchenko wrote:
> On Wed, Mar 05, 2025 at 10:10:25AM +0000, George Cherian wrote:
>> Watchdog is not turned off in kernel panic situation.
>> In certain systems this might prevent the successful loading
>> of kdump kernel. The kdump kernel might hit a watchdog reset
>> while it is booting.
>>
>> To avoid such scenarios add a panic notifier call back function
>> which can stop the watchdog. This provision can be enabled by
>> passing watchdog.stop_on_panic=1 via kernel command-line parameter.
> 
> ...
> 
> First of all, do we really need a new module parameter for that? Why can't it
> be done automatically if kdump is expected?
> 

Sounds like a good idea to me.

Guenter