linux-kernel - Re: [PATCH] ARM64: dts: imx8mp-evk: add ecspi2 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8oqhGmVOBCPlJUI@lizhi-Precision-Tower-5810>
Date: Thu, 6 Mar 2025 18:06:44 -0500
From: Frank Li <Frank.li@....com>
To: Fabio Estevam <festevam@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM64: dts: imx8mp-evk: add ecspi2 support

On Thu, Mar 06, 2025 at 07:55:36PM -0300, Fabio Estevam wrote:
> On Thu, Mar 6, 2025 at 7:24 PM Frank Li <Frank.Li@....com> wrote:
>
> > +&ecspi2 {
> > +       #address-cells = <1>;
> > +       #size-cells = <0>;
> > +       num-cs = <1>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
> > +       cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> > +       status = "okay";
> > +
> > +       spidev1: spi@0 {
> > +               compatible = "rohm,dh2228fv";
>
> That's not a correct description of the hardware.
>
> Conor's effort was to clean up the abuses of using "rohm,dh2228fv" to
> get spidev support.
>
> Please check:
>
> fc28d1c1fe3b3 ("spi: spidev: add correct compatible for Rohm BH2228FV")

Thanks! It is actually to get spidev. From commit message, I don't know
what next steps should be did, use "rohm,bh2228fv" or other method to
support spidev?

Frank