linux-kernel - Re: [PATCH v7 1/2] counter: microchip-tcb-capture: Add IRQ handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8k3WlJHCrYPdW4j@ishi>
Date: Thu, 6 Mar 2025 14:49:14 +0900
From: William Breathitt Gray <wbg@...nel.org>
To: Bence Csókás <csokas.bence@...lan.hu>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-iio@...r.kernel.org,
	Kamel Bouhara <kamel.bouhara@...tlin.com>
Subject: Re: [PATCH v7 1/2] counter: microchip-tcb-capture: Add IRQ handling

On Tue, Mar 04, 2025 at 04:51:51PM +0100, Bence Csókás wrote:
> Add interrupt servicing to allow userspace to wait for the following:
> * Change-of-state caused by external trigger
> * Capture of timer value into RA/RB
> * Compare to RC register
> * Overflow
> 
> Signed-off-by: Bence Csókás <csokas.bence@...lan.hu>

Hi Bence,

I'm mostly statisfied with this patch now, but I have one minor
suggestion below.

> @@ -27,6 +33,7 @@ struct mchp_tc_data {
>  	int qdec_mode;
>  	int num_channels;
>  	int channel[2];
> +	int irq;

We don't use the irq member during the driver operation, so I don't
think this value needs to be saved here with the driver data. It seems
to only be needed in mchp_tc_irq_enable() for devm_request_irq().
Perhaps you can pass the irq value as a parameter to
mchp_tc_irq_enable() instead.

With that change made, I think I'll be ready to pick up this patchset
and merge it into counter-next.

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)