[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250306091256.2f0e2e86@bootlin.com>
Date: Thu, 6 Mar 2025 09:12:56 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Maxime Ripard <mripard@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann
<tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter
<simona@...ll.ch>, Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong
<neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, Laurent
Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman
<jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, Douglas
Anderson <dianders@...omium.org>, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, Simona Vetter <simona.vetter@...ll.ch>
Subject: Re: [PATCH v5 08/16] drm/bridge: Add helper to reset bridge
pipeline
Hi Maxime,
On Tue, 04 Mar 2025 12:10:51 +0100
Maxime Ripard <mripard@...nel.org> wrote:
> Let's provide an helper to make it easier for bridge drivers to
> power-cycle their bridge.
>
> In order to avoid a circular dependency between that new helper and
> drm_atomic_helper_reset_crtc(), this new helper will be in a
> drm_bridge_helper.c file to follow the pattern we have for other
> objects.
>
> Co-developed-by: Simona Vetter <simona.vetter@...ll.ch>
> Signed-off-by: Maxime Ripard <mripard@...nel.org>
> ---
> drivers/gpu/drm/Makefile | 1 +
> drivers/gpu/drm/drm_bridge_helper.c | 55 +++++++++++++++++++++++++++++++++++++
> include/drm/drm_bridge_helper.h | 12 ++++++++
> 3 files changed, 68 insertions(+)
>
Reviewed-by: Herve Codina <herve.codina@...tlin.com>
Also tested on my system using the ti-sn65dsi83 driver (updated in this series)
with faults manually generated on the hardware. No regressions were observed in
the driver recovery process. Works fine.
Tested-by: Herve Codina <herve.codina@...tlin.com>
Best regards,
Hervé
Powered by blists - more mailing lists