linux-kernel - Re: [PATCH v2] ktest: Fix Test Failures Due to Missing LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250305190159.7c590242@gandalf.local.home>
Date: Wed, 5 Mar 2025 19:01:59 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Ayush Jain <Ayush.jain3@....com>
Cc: <warthog9@...lescrag.net>, <linux-kernel@...r.kernel.org>,
 <srikanth.aithal@....com>, <kalpana.shetty@....com>
Subject: Re: [PATCH v2] ktest: Fix Test Failures Due to Missing LOG_FILE
 Directories

On Wed, 5 Mar 2025 04:19:13 +0000
Ayush Jain <Ayush.jain3@....com> wrote:

> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index 8c8da966c641..13b97e6b8459 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -4303,6 +4303,14 @@ if (defined($opt{"LOG_FILE"})) {
>      if ($opt{"CLEAR_LOG"}) {
>  	unlink $opt{"LOG_FILE"};
>      }
> +
> +	if (! -e $opt{"LOG_FILE"} && $opt{"LOG_FILE"} =~ m,^(.*/),) {
> +	my $dir = $1;
> +	if (! -d $dir) {
> +	mkpath($dir) or die "Failed to create directories '$dir': $!";
> +	print "\nThe log directory $dir did not exist, so it was created.\n";
> +	}
> +	}

Hmm, somehow the indentation is messed up here. Should be:

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 8c8da966c641..13b97e6b8459 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -4303,6 +4303,14 @@ if (defined($opt{"LOG_FILE"})) {
     if ($opt{"CLEAR_LOG"}) {
 	unlink $opt{"LOG_FILE"};
     }
+
+    if (! -e $opt{"LOG_FILE"} && $opt{"LOG_FILE"} =~ m,^(.*/),) {
+	my $dir = $1;
+	if (! -d $dir) {
+	    mkpath($dir) or die "Failed to create directories '$dir': $!";
+	    print "\nThe log directory $dir did not exist, so it was created.\n";
+	}
+    }

-- Steve