linux-kernel - Re: [PATCH] media: vim2m: print device name after registering device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06766086-b148-436c-b6d4-975c26493233@xs4all.nl>
Date: Thu, 6 Mar 2025 09:37:09 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Shuah Khan <skhan@...uxfoundation.org>,
 Matthew Majewski <mattwmajewski@...il.com>,
 Uwe Kleine-Konig <u.kleine-koenig@...libre.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: vim2m: print device name after registering device

Hi Shuah,

On 20/02/2025 17:27, Shuah Khan wrote:
> On 2/20/25 08:29, Matthew Majewski wrote:
>> On Wed, 2025-02-19 at 17:21 -0700, Shuah Khan wrote:
>>> On 2/19/25 14:58, Uwe Kleine-Konig wrote:
>>>> On Wed, Feb 19, 2025 at 02:05:01PM -0500, Matthew Majewski wrote:
>>>>> Move the v4l2_info() call displaying the video device name after
>>>>> the
>>>>> device is actually registered.
>>>>>
>>>>> This fixes a bug where the driver was always displaying
>>>>> "/dev/video0"
>>>>> since it was reading from the vfd before it was registered.
>>>>>
>>>>> Signed-off-by: Matthew Majewski <mattwmajewski@...il.com>
>>>>
>>>> A Fixes: tag would be great.
>>>
>>> Matthew, there is no need to resend the patch. Just send me the
>>> Fixes tag and I will update the repo.
>>>
>>>
>>
>> Ok, here is the fixes tag:
>>
>> Fixes: cf7f34777a5b4100a ("media: vim2m: Register video device after
>> setting up internals")
>>
> 
> Thank you. commit is now updated.
> 
> thanks,
> -- Shuah
> 

Please post your PR today, if possible. Otherwise it might slip to the
v6.16. Alternatively, I can take this patch myself.

Also, why did you pick up this vim2m patch? I was a bit surprised by that.

Regards,

	Hans