linux-kernel - Re: [PATCH] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4081d99c-1283-45a4-9cb8-8e6f8dbd635d@foss.st.com>
Date: Thu, 6 Mar 2025 09:37:15 +0100
From: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>, <tglx@...utronix.de>
CC: <alexandre.torgue@...s.st.com>, <olivier.moysan@...s.st.com>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH] clocksource: stm32-lptimer: use wakeup capable instead of
 init wakeup

On 3/5/25 18:23, Daniel Lezcano wrote:
> On 05/03/2025 13:51, Fabrice Gasnier wrote:
>> From: Alexandre Torgue <alexandre.torgue@...s.st.com>
>>
>> "wakeup-source" property describes a device which has wakeup capability
>> but should not force this device as a wakeup source.
> 
> Is that a fix to be carried on ?

Hi Daniel,

Thanks for reviewing,
I just have sent a V2 with Fixes tag, and have CC'ed stable.

Please review there,
Best Regards,
Fabrice

Fixes: 48b41c5e2de6 ("clocksource: Add Low Power STM32 timers driver")
> 
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@...s.st.com>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
>> ---
>>   drivers/clocksource/timer-stm32-lp.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/clocksource/timer-stm32-lp.c
>> b/drivers/clocksource/timer-stm32-lp.c
>> index 96d975adf7a4..f08baa6720f8 100644
>> --- a/drivers/clocksource/timer-stm32-lp.c
>> +++ b/drivers/clocksource/timer-stm32-lp.c
>> @@ -186,9 +186,7 @@ static int stm32_clkevent_lp_probe(struct
>> platform_device *pdev)
>>       }
>>         if (of_property_read_bool(pdev->dev.parent->of_node,
>> "wakeup-source")) {
>> -        ret = device_init_wakeup(&pdev->dev, true);
>> -        if (ret)
>> -            goto out_clk_disable;
>> +        device_set_wakeup_capable(&pdev->dev, true);
>>             ret = dev_pm_set_wake_irq(&pdev->dev, irq);
>>           if (ret)
> 
>