linux-kernel - Re: [PATCH v3 07/18] cxl/region: Avoid duplicate call of cxl_find_decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8loAbQJAFQvX-9A@rric.localdomain>
Date: Thu, 6 Mar 2025 10:16:49 +0100
From: Robert Richter <rrichter@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org, Gregory Price <gourry@...rry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Terry Bowman <terry.bowman@....com>
Subject: Re: [PATCH v3 07/18] cxl/region: Avoid duplicate call of
 cxl_find_decoder_early()

On 14.02.25 16:07:25, Jonathan Cameron wrote:
> On Tue, 11 Feb 2025 10:53:37 +0100
> Robert Richter <rrichter@....com> wrote:
> 
> > Function cxl_find_decoder_early() is called twice, in
> > alloc_region_ref() and cxl_rr_alloc_decoder(). Move it out there and
> 
> out where?  I'd make it clear that both these calls are in
> cxl_port_attach_region()
> 
> > instead pass the decoder as function argument to both.
> > 
> > Signed-off-by: Robert Richter <rrichter@....com>
> > Reviewed-by: Gregory Price <gourry@...rry.net>
> > Tested-by: Gregory Price <gourry@...rry.net>
> 
> I think this is fine but it's not immediately obvious so a request
> inline for some more details in this description.

I have updated the patch description.

-Robert