linux-kernel - Re: [PATCH net v2] net/mlx5: handle errors in mlx5_chains_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90902747-b976-4653-8d9d-0371f168bdbb@gmail.com>
Date: Thu, 6 Mar 2025 11:19:14 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Wentao Liang <vulab@...as.ac.cn>, saeedm@...dia.com, leon@...nel.org,
 tariqt@...dia.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net v2] net/mlx5: handle errors in
 mlx5_chains_create_table()



On 06/03/2025 10:54, Wentao Liang wrote:
> In mlx5_chains_create_table(), the return value of mlx5_get_fdb_sub_ns()
> and mlx5_get_flow_namespace() must be checked to prevent NULL pointer
> dereferences. If either function fails, the function should log error
> message with mlx5_core_warn() and return error pointer.
> 
> [v1]->[v2]:
> Add Fixes tag.
> Target patch to net.
> Change return value from NULL to ERR_PTR(-EOPNOTSUPP)
> 

Change history should not be part of the commit message.
Please move it to under the "---" marker below.

> Fixes: ae430332557a ("net/mlx5: Refactor multi chains and prios support")

Same problem existed also in mlx5_esw_chains_create_fdb_table(), before 
the refactoring.
Please refer to the original patch where issue was introduced, seems to 
be commit 39ac237ce009 ("net/mlx5: E-Switch, Refactor chains and 
priorities").