linux-kernel - RE: [PATCH v1] USB: serial: ftdi_sio: add support for Altera USB Blaster 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM8PR11MB5751B5E8FAD650C31AE12410C1CA2@DM8PR11MB5751.namprd11.prod.outlook.com>
Date: Thu, 6 Mar 2025 10:25:25 +0000
From: "Ng, Boon Khai" <boon.khai.ng@...el.com>
To: Johan Hovold <johan@...nel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Ang, Tien
 Sung" <tien.sung.ang@...el.com>, Tien Sung Ang <tien.sung.ang@...era.com>,
	Boon Khai Ng <boon.khai.ng@...era.com>
Subject: RE: [PATCH v1] USB: serial: ftdi_sio: add support for Altera USB
 Blaster 3

> > There are 2 type of designs, USB Blaster 3 cable or On-Board USB Blaster 3.
> > They are mainly used to connect debug or configuration software.
> > Supported host software includes Quartus programmer, System Console,
> > SignalTap, Nios debugger.
> 
> Thanks for the background. It would be good to have something like this in the
> commit message.
> 

Will add that in the next version.

> Got it, thanks. Also here it would be good to include something like the above,
> or a compact table like you provided in your reply to David, in the commit
> message to have some overview of the configurations that the patch is
> adding.
> 

Sure, adding that in the next version as well.
 
> Then it should be fine to keep the PID in the define name. Just replace "ALTR"
> with "ALTERA" for consistency with the renamed VID define.
> 

Okay, will update all ALTR define, to ALTERA, to align with the proposed
VID define earlier.